Attention is currently required from: Arthur Heymans, Jonathan Zhang, Johnny Lin, Rocky Phagura, Paul Menzel, Shuming Chu (Shuming), Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68758 )
Change subject: drivers/ipmi/ocp: add PCIe SEL support ......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/drivers/ipmi/ocp/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/68758/comment/ae6ee476_155d2b7e PS3, Line 111: /* PCIE CE */ : #define RECEIVER_ERROR 0x00 : #define BAD_TLP 0x01 : #define BAD_DLLP 0x02 : #define REPLAY_TIME_OUT 0x03 : #define REPLAY_NUMBER_ROLLOVER 0x04 : #define ADVISORY_NONFATAL_ERROR_STATUS 0x05 : #define CORRECTED_INTERNAL_ERROR_STATUS 0x06 : #define HEADER_LOG_OVERFLOW_STATUS 0x07 : : /* PCIE UCE */ : #define PCI_EXPRESS_DATA_LINK_PROTOCOL_ERROR 0x20 : #define SURPRISE_DOWN_ERROR 0x21 : #define RECEIVED_PCI_EXPRESS_POISONED_TLP 0x22 : #define PCI_EXPRESS_FLOW_CONTROL_PROTOCOL_ERROR 0x23 : #define COMPLETION_TIMEOUT_ON_NP_TRANSACTIONS_OUTSTANDING_ON_PCI_EXPRESS_DMI 0x24 : #define RECEIVED_A_REQUEST_FROM_A_DOWNSTREAM_COMPONENT_THAT_IS_TO_BE_COMPLETER_ABORTED 0x25 : #define RECEIVED_PCI_EXPRESS_UNEXPECTED_COMPLETION 0x26 : #define PCI_EXPRESS_RECEIVER_OVERFLOW 0x27 : #define PCI_EXPRESS_MALFORMED_TLP 0x28 : #define ECRC_ERROR_STATUS 0x29 : #define RECEIVED_A_REQUEST_FROM_A_DOWNSTREAM_COMPONENT_THAT_IS_UNSUPPORTED 0x2A : #define ACS_VIOLATION 0x2B : #define UNCORRECTABLE_INTERNAL_ERROR_STATUS 0x2C : #define MC_BLOCKED_TLP 0x2D : #define ATOMICOP_EGRESS_BLOCKED_STATUS 0x2E : #define TLP_PREFIX_BLOCKED_ERROR_STATUS 0x2F : #define POISONED_TLP_EGRESS_BLOCKED 0x30
As Jonathan mentioned, these macros are used for SEL (in Error ID field). […]
Ack
-
Angel Pons (Code Review)