Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58980 )
Change subject: lib/thread: Remove printk in thread_mutex_lock ......................................................................
lib/thread: Remove printk in thread_mutex_lock
While helpful, it will cause a dead lock with the next CL that adds a mutex in printk.
BUG=b:179699789 TEST=Boot guybrush to OS
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I5a28f9c777fc0fb3bb73dff9e0974aeb6e210bba --- M src/lib/thread.c 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/58980/1
diff --git a/src/lib/thread.c b/src/lib/thread.c index 7d5cdc5..4409d97 100644 --- a/src/lib/thread.c +++ b/src/lib/thread.c @@ -412,15 +412,9 @@
void thread_mutex_lock(struct thread_mutex *mutex) { - struct stopwatch sw; - - stopwatch_init(&sw); - while (mutex->locked) assert(thread_yield() == 0); mutex->locked = true; - - printk(BIOS_SPEW, "took %lu us to acquire mutex\n", stopwatch_duration_usecs(&sw)); }
void thread_mutex_unlock(struct thread_mutex *mutex)