Change in ...coreboot[master]: mb/google/poppy/variant/nocturne: change speaker IV channels
Jenny Tc has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31636
Change subject: mb/google/poppy/variant/nocturne: change speaker IV channels ......................................................................
mb/google/poppy/variant/nocturne: change speaker IV channels
Change speaker IV channels for max98373 to match with 24 bit topology firmware
BUG=b:110795132 BRANCH=none TEST=Verify playback after flashing CQ-DEPEND=*806750
Change-Id: I5d94d473b25b23e206c998ca9bd8bd776b76d2bb Signed-off-by: Jenny TC jenny.tc@intel.com --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31636/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 4d9403c..5b84c96 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -403,16 +403,16 @@ end # I2C #5 device pci 19.2 on chip drivers/i2c/max98373 - register "vmon_slot_no" = "4" - register "imon_slot_no" = "5" + register "vmon_slot_no" = "1" + register "imon_slot_no" = "0" register "uid" = "0" register "desc" = ""RIGHT SPEAKER AMP"" register "name" = ""MAXR"" device i2c 32 on end end chip drivers/i2c/max98373 - register "vmon_slot_no" = "6" - register "imon_slot_no" = "7" + register "vmon_slot_no" = "3" + register "imon_slot_no" = "2" register "uid" = "1" register "desc" = ""LEFT SPEAKER AMP"" register "name" = ""MAXL""
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31636
to look at the new patch set (#2).
Change subject: mb/google/poppy/variant/nocturne: change speaker IV channels ......................................................................
mb/google/poppy/variant/nocturne: change speaker IV channels
Change speaker IV channels for max98373 to match with 24 bit topology firmware
BUG=b:110795132 BRANCH=none TEST=Verify playback after flashing CQ-DEPEND=CL:1547644
Change-Id: I5d94d473b25b23e206c998ca9bd8bd776b76d2bb Signed-off-by: Jenny TC jenny.tc@intel.com --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31636/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31636 )
Change subject: mb/google/poppy/variant/nocturne: change speaker IV channels ......................................................................
Patch Set 2:
Ideally these CLs for nocturne and atlas should be squashed into the soc CL since they need to land as a single unit.
Jenny Tc has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31636 )
Change subject: mb/google/poppy/variant/nocturne: change speaker IV channels ......................................................................
Patch Set 2:
Patch Set 2:
Ideally these CLs for nocturne and atlas should be squashed into the soc CL since they need to land as a single unit.
Okay will abandon atlas and nocturne changes
Jenny Tc has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31636 )
Change subject: mb/google/poppy/variant/nocturne: change speaker IV channels ......................................................................
Abandoned
Squashed into soc CL (https://review.coreboot.org/c/coreboot/+/31635)
-
Furquan Shaikh (Code Review) -
Jenny Tc (Code Review)