[M] Change in coreboot[master]: drivers/mrc_cache: Prevent printing errors in expected use cases
Attention is currently required from: Shelley Chen, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69542 )
Change subject: drivers/mrc_cache: Prevent printing errors in expected use cases ......................................................................
Patch Set 2:
(3 comments)
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/69542/comment/02712c7e_0590a12c PS1, Line 159: printk(BIOS_WARNING, "MRC: failed to locate region type %d\n", type);
I feel like you might even want to go further and make this BIOS_DEBUG (with a comment explaining wh […]
Done
https://review.coreboot.org/c/coreboot/+/69542/comment/8eb5218e_f2e13855 PS1, Line 180: BIOS_WARNING
INFO maybe?
Done
https://review.coreboot.org/c/coreboot/+/69542/comment/300c7503_2d446dc0 PS1, Line 275: printk(BIOS_WARNING, "MRC: invalid header in '%s'\n", name);
Maybe just remove this? Not sure why we need to print again here if the function already prints in a […]
I thought the `name` might be useful. However, there's already a debug message printed in `fmap_locate_area`, so removing this should be fine.
-
Yu-Ping Wu (Code Review)