Change in ...coreboot[master]: device/mmio.h: Add include file for MMIO ops - coreboot-gerrit

2 Mar 2019


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31691 )
Change subject: device/mmio.h: Add include file for MMIO ops
......................................................................
Patch Set 2:
I'm confused, when exactly should the include path be
`arch/`? I thought it makes sense when the interface is
common but the implementation is not. Which might be
the case for MMIO, or isn't it?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31691
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fd70f5aeca02e98e96b980c3aca0819f5c44b98
Gerrit-Change-Number: 31691
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: David Guckian david.guckian@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Huang Jin huang.jin@intel.com
Gerrit-Reviewer: Jonathan Neuschäfer j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 02 Mar 2019 19:44:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment