Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81101?usp=email )
Change subject: mb/amd/birman/devicetree_phoenix_opensil: add stub MPIO chips
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81101/comment/9c1966bb_d5112233 :
PS4, Line 22:
may be add the test info, may be a build check..
only did a build test and no test on real hardware, since this is just the stub. that it compiles is at least to me obvious due to jenkins not complaining (and also having tested that before i pushed), so i don't think that adding that line would add some info
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81101?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icabe60322d46c1195284dd77ec39f9d143e3d2cb
Gerrit-Change-Number: 81101
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 30 Apr 2024 15:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-MessageType: comment