Change in coreboot[master]: util/crossgcc: curl must write downloaded bytes to a file

[Idwer Vollering (Code Review)]

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47911 )

Change subject: util/crossgcc: curl must write downloaded bytes to a file
......................................................................

util/crossgcc: curl must write downloaded bytes to a file

How curl would behave has been changed, and broken, in commit 82a30a134c.

Signed-off-by: Idwer Vollering 
Change-Id: I0d946b86baad3f6409a5042701808da307e5bcb7
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/47911/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index bba8ac7..01c4f86 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -1066,7 +1066,7 @@
    download_showing_percentage() {
    	url=$1
    	echo
-		curl --progress-bar --location --retry 3 "$url"
+		curl -O --progress-bar --location --retry 3 "$url"
    }
 fi

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47911 )

Change subject: util/crossgcc: curl must write downloaded bytes to a file
......................................................................

Patch Set 1: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/47911/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47911/1//COMMIT_MSG@7 
PS1, Line 7: curl must write downloaded bytes to a file
Maybe:

Ensure curl writes downloaded bytes to a file

https://review.coreboot.org/c/coreboot/+/47911/1//COMMIT_MSG@9 
PS1, Line 9: How curl would behave has been changed, and broken, in commit 82a30a134c.
Maybe:

Commit 82a30a134c (util/crossgcc: Retry package downloads on failure) caused a regression for curl users.

Change in coreboot[master]: util/crossgcc: ensure curl writes downloaded bytes to a file

[Idwer Vollering (Code Review)]

Hello Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47911

to look at the new patch set (#2).

Change subject: util/crossgcc: ensure curl writes downloaded bytes to a file
......................................................................

util/crossgcc: ensure curl writes downloaded bytes to a file

Commit 82a30a134c (util/crossgcc: Retry package downloads on failure) caused a regression for curl users.

Signed-off-by: Idwer Vollering 
Change-Id: I0d946b86baad3f6409a5042701808da307e5bcb7
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/47911/2

Change in coreboot[master]: util/crossgcc: ensure curl writes downloaded bytes to a file

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47911 )

Change subject: util/crossgcc: ensure curl writes downloaded bytes to a file
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47911/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47911/2//COMMIT_MSG@9 
PS2, Line 9: caused a regression for curl users.
please wrap this

Change in coreboot[master]: util/crossgcc: ensure curl writes downloaded bytes to a file

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47911 )

Change subject: util/crossgcc: ensure curl writes downloaded bytes to a file
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47911/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47911/1//COMMIT_MSG@7 
PS1, Line 7: curl must write downloaded bytes to a file
> Maybe: […]

Done

https://review.coreboot.org/c/coreboot/+/47911/1//COMMIT_MSG@9 
PS1, Line 9: How curl would behave has been changed, and broken, in commit 82a30a134c.
> Maybe: […]

Done

https://review.coreboot.org/c/coreboot/+/47911/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47911/2//COMMIT_MSG@9 
PS2, Line 9: caused a regression for curl users.
> please wrap this

Done

Change in coreboot[master]: util/crossgcc: ensure curl writes downloaded bytes to a file

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47911 )

Change subject: util/crossgcc: ensure curl writes downloaded bytes to a file
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: util/crossgcc: ensure curl writes downloaded bytes to a file

[Idwer Vollering (Code Review)]

Idwer Vollering has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47911 )

Change subject: util/crossgcc: ensure curl writes downloaded bytes to a file
......................................................................

util/crossgcc: ensure curl writes downloaded bytes to a file

Commit 82a30a134c (util/crossgcc: Retry package downloads on failure) caused a regression for curl users.

Signed-off-by: Idwer Vollering 
Change-Id: I0d946b86baad3f6409a5042701808da307e5bcb7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47911
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
Reviewed-by: Angel Pons 
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index b55ecb2..5af3d5a 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -1066,7 +1066,7 @@
    download_showing_percentage() {
    	url=$1
    	echo
-		curl --progress-bar --location --retry 3 "$url"
+		curl -O --progress-bar --location --retry 3 "$url"
    }
 fi