Raul Rangel has posted comments on this change. ( https://review.coreboot.org/27884 )
Change subject: security/vboot: Split fwid.region build target
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc@232
PS1, Line 232: file
This function will only work for make version 4.2 and higher.For lower version it'll give an error. […]
I wasn't aware. I'll change it to use what Julius suggested.
--
To view, visit
https://review.coreboot.org/27884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I955106efd648a75a1311f24ede46bd238d1517e0
Gerrit-Change-Number: 27884
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Thu, 09 Aug 2018 14:09:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No