Attention is currently required from: Felix Singer, Nico Huber, Arthur Heymans, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49289 )
Change subject: nb/intel/sandybridge: Split receive enable calibration ......................................................................
Patch Set 1:
(8 comments)
File src/northbridge/intel/sandybridge/raminit/rcven.c:
https://review.coreboot.org/c/coreboot/+/49289/comment/192e8f5d_a1ebadc1 PS1, Line 204: FOR_ALL_LANES if (works[lane]) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/49289/comment/e53db959_fa1cd8a6 PS1, Line 244: latency_offset = +1; need consistent spacing around '+' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49289/comment/c8e61e4a_970ed784 PS1, Line 359: FOR_ALL_LANES function definition argument 'channel' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/49289/comment/7a1d4a2a_ce2da1b1 PS1, Line 359: FOR_ALL_LANES function definition argument 'rank' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/49289/comment/83bfce44_1a233825 PS1, Line 359: FOR_ALL_LANES function definition argument 'lane' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/49289/comment/2b9e8daa_5cad8b35 PS1, Line 359: FOR_ALL_LANES function definition argument 'channel' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/49289/comment/0e4579a2_9c28b1b3 PS1, Line 359: FOR_ALL_LANES function definition argument 'rank' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/49289/comment/1cbfe83f_dd4a079c PS1, Line 359: FOR_ALL_LANES function definition argument 'lane' should also have an identifier name
-
build bot (Jenkins) (Code Review)