Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56695 )
Change subject: soc/intel/common/block/cpu: Add core recovery feature support ......................................................................
Patch Set 1:
(3 comments)
File src/soc/intel/common/block/cpu/mp_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125441): https://review.coreboot.org/c/coreboot/+/56695/comment/24fb2a74_031d9376 PS1, Line 155: if(!CONFIG(CPU_SUPPORTS_CORE_RECOVERY)) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125441): https://review.coreboot.org/c/coreboot/+/56695/comment/3ba3d599_e5c34e12 PS1, Line 163: if(dev->path.apic.apic_id != bsp_apic_id) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125441): https://review.coreboot.org/c/coreboot/+/56695/comment/4855a94b_2a6bf479 PS1, Line 164: dev->path.apic.apic_id = bsp_apic_id; code indent should use tabs where possible