Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44258 )
Change subject: Kconfig: Update ASan config options ......................................................................
Kconfig: Update ASan config options
Instead of enabling ASAN_IN_ROMSTAGE from Kconfig file in a platform's dedicated directory, let's introduce a new config option HAVE_ASAN_IN_ROMSTAGE to denote if a given platform supports ASan in romstage.
Similary, use HAVE_ASAN_IN_RAMSTAGE to indicate if a given platform supports ASan in ramstage. Consequently, we no longer have to make ASan x86 specific.
Change-Id: I36b144305465052718f245cacf61d3ca44dfb4b4 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/Kconfig 1 file changed, 25 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44258/1
diff --git a/src/Kconfig b/src/Kconfig index 447755b..d6b703b 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -270,10 +270,31 @@ say N because it adds a small performance penalty and may abort on code that happens to work in spite of the UB.
-config ASAN_IN_RAMSTAGE - bool "Address sanitizer support" - depends on ARCH_X86 +config HAVE_ASAN_IN_ROMSTAGE + bool default n + +config ASAN_IN_ROMSTAGE + bool + default n + help + Enable address sanitizer in romstage for platform. + +config HAVE_ASAN_IN_RAMSTAGE + bool + default n + +config ASAN_IN_RAMSTAGE + bool + default n + help + Enable address sanitizer in ramstage for platform. + +config ASAN + bool "Address sanitizer support" + default n + select ASAN_IN_ROMSTAGE if HAVE_ASAN_IN_ROMSTAGE + select ASAN_IN_RAMSTAGE if HAVE_ASAN_IN_RAMSTAGE help Enable address sanitizer - runtime memory debugger, designed to find out-of-bounds accesses and use-after-scope bugs. @@ -283,18 +304,11 @@
If unsure, say N.
-if ASAN_IN_RAMSTAGE +if ASAN comment "Before using this feature, make sure that " comment "asan_shadow_offset_callback patch is applied to GCC." endif
-config ASAN_IN_ROMSTAGE - bool - depends on ASAN_IN_RAMSTAGE - default n - help - Enable address sanitizer in romstage for platform. - choice prompt "Stage Cache for ACPI S3 resume" default NO_STAGE_CACHE if !HAVE_ACPI_RESUME
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44258 )
Change subject: Kconfig: Update ASan config options ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44258/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44258/1//COMMIT_MSG@10 PS1, Line 10: platform's platforms
Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44258 )
Change subject: Kconfig: Update ASan config options ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44258/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44258/1//COMMIT_MSG@10 PS1, Line 10: platform's
platforms
I think it is grammatically correct.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44258 )
Change subject: Kconfig: Update ASan config options ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44258/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44258/1//COMMIT_MSG@10 PS1, Line 10: platform's
I think it is grammatically correct.
Yeah, you are right, sorry.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44258 )
Change subject: Kconfig: Update ASan config options ......................................................................
Kconfig: Update ASan config options
Instead of enabling ASAN_IN_ROMSTAGE from Kconfig file in a platform's dedicated directory, let's introduce a new config option HAVE_ASAN_IN_ROMSTAGE to denote if a given platform supports ASan in romstage.
Similary, use HAVE_ASAN_IN_RAMSTAGE to indicate if a given platform supports ASan in ramstage. Consequently, we no longer have to make ASan x86 specific.
Change-Id: I36b144305465052718f245cacf61d3ca44dfb4b4 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44258 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/Kconfig 1 file changed, 25 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 447755b..d6b703b 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -270,10 +270,31 @@ say N because it adds a small performance penalty and may abort on code that happens to work in spite of the UB.
-config ASAN_IN_RAMSTAGE - bool "Address sanitizer support" - depends on ARCH_X86 +config HAVE_ASAN_IN_ROMSTAGE + bool default n + +config ASAN_IN_ROMSTAGE + bool + default n + help + Enable address sanitizer in romstage for platform. + +config HAVE_ASAN_IN_RAMSTAGE + bool + default n + +config ASAN_IN_RAMSTAGE + bool + default n + help + Enable address sanitizer in ramstage for platform. + +config ASAN + bool "Address sanitizer support" + default n + select ASAN_IN_ROMSTAGE if HAVE_ASAN_IN_ROMSTAGE + select ASAN_IN_RAMSTAGE if HAVE_ASAN_IN_RAMSTAGE help Enable address sanitizer - runtime memory debugger, designed to find out-of-bounds accesses and use-after-scope bugs. @@ -283,18 +304,11 @@
If unsure, say N.
-if ASAN_IN_RAMSTAGE +if ASAN comment "Before using this feature, make sure that " comment "asan_shadow_offset_callback patch is applied to GCC." endif
-config ASAN_IN_ROMSTAGE - bool - depends on ASAN_IN_RAMSTAGE - default n - help - Enable address sanitizer in romstage for platform. - choice prompt "Stage Cache for ACPI S3 resume" default NO_STAGE_CACHE if !HAVE_ACPI_RESUME
-
Harshit Sharma (Code Review) -
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)