build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: [WIP]mainboard/lenovo/t410: Add new port ......................................................................
Patch Set 13:
(10 comments)
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/romstage.... File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/romstage.... PS13, Line 65: (pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) & ~2) | 1); line over 80 characters
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/romstage.... PS13, Line 141: unsigned i; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/romstage.... PS13, Line 271: pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) | 2); line over 80 characters
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... File src/mainboard/lenovo/t410/smihandler.c:
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 52: switch (smif) { switch and case should be at the same indent
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 55: udelay(250000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 81: if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0) do not use assignment in if condition
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 89: if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10) do not use assignment in if condition
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 105: switch (event) { switch and case should be at the same indent
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 142: switch (data) { switch and case should be at the same indent
https://review.coreboot.org/#/c/11791/13/src/mainboard/lenovo/t410/smihandle... PS13, Line 166: /* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't line over 80 characters
-
build bot (Jenkins) (Code Review)