Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38392 )
Change subject: drivers/i2c/at24rf08c: Move opening bracket to line above ......................................................................
drivers/i2c/at24rf08c: Move opening bracket to line above
Adhere to the coding style.
Change-Id: Ia12a4ed6ab2fb2c9848a2688b41fcfa70ab001b0 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/drivers/i2c/at24rf08c/at24rf08c.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38392/1
diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c index daf04a9..b1ea6fa 100644 --- a/src/drivers/i2c/at24rf08c/at24rf08c.c +++ b/src/drivers/i2c/at24rf08c/at24rf08c.c @@ -31,8 +31,7 @@
printk (BIOS_DEBUG, "Locking EEPROM RFID\n");
- for (i = 0; i < 8; i++) - { + for (i = 0; i < 8; i++) { /* After a register write AT24RF08C sometimes stops responding. Retry several times in case of failure. */ for (j = 0; j < 100; j++)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38392
to look at the new patch set (#2).
Change subject: drivers/i2c/at24rf08c: Format according to coding style ......................................................................
drivers/i2c/at24rf08c: Format according to coding style
1. Move opening bracket to line above 2. Remove space after `printk` statements
Change-Id: Ia12a4ed6ab2fb2c9848a2688b41fcfa70ab001b0 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/drivers/i2c/at24rf08c/at24rf08c.c 1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/38392/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38392 )
Change subject: drivers/i2c/at24rf08c: Format according to coding style ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38392 )
Change subject: drivers/i2c/at24rf08c: Format according to coding style ......................................................................
drivers/i2c/at24rf08c: Format according to coding style
1. Move opening bracket to line above 2. Remove space after `printk` statements
Change-Id: Ia12a4ed6ab2fb2c9848a2688b41fcfa70ab001b0 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/38392 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/drivers/i2c/at24rf08c/at24rf08c.c 1 file changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c index daf04a9..11a6fd2 100644 --- a/src/drivers/i2c/at24rf08c/at24rf08c.c +++ b/src/drivers/i2c/at24rf08c/at24rf08c.c @@ -29,10 +29,9 @@ if (dev->path.type != DEVICE_PATH_I2C || dev->path.i2c.device != 0x5c) return;
- printk (BIOS_DEBUG, "Locking EEPROM RFID\n"); + printk(BIOS_DEBUG, "Locking EEPROM RFID\n");
- for (i = 0; i < 8; i++) - { + for (i = 0; i < 8; i++) { /* After a register write AT24RF08C sometimes stops responding. Retry several times in case of failure. */ for (j = 0; j < 100; j++) @@ -40,7 +39,7 @@ break; }
- printk (BIOS_DEBUG, "init EEPROM done\n"); + printk(BIOS_DEBUG, "init EEPROM done\n"); }
static struct device_operations at24rf08c_operations = {
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)