Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86551?usp=email )
Change subject: soc/mediatek/mt8196: Save HW protect temperature to SRAM
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8196/thermal.c:
https://review.coreboot.org/c/coreboot/+/86551/comment/d68056e2_dada66bd?usp... :
PS2, Line 606: if (tc_num == LVTS_AP_CONTROLLER0)
: tc_index = 0;
: else if (tc_num == LVTS_AP_CONTROLLER1)
: tc_index = 1;
:
: if (tc_index != 0xff) {
: thermal_write_reboot_msr_sram(tc_index, raw_high);
: if (tc_index == 0)
: thermal_write_reboot_temp_sram(tc->reboot_temperature);
: }
Yes, remove from lvts_tscpu_g_tc list. As no plan to enable them.
Please do it in a separate patch.
I am fine with this if there is only two entries.
```
thermal_write_reboot_msr_sram(tc_num, raw_high);
if (tc_num == LVTS_AP_CONTROLLER0)
thermal_write_reboot_temp_sram(tc->reboot_temperature);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86551?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib714c297871132907e286536c4b3aea1532f3869
Gerrit-Change-Number: 86551
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 27 Feb 2025 06:31:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com