Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67304 )
Change subject: mb/google/skyrim: Enable ASPM for SD ......................................................................
mb/google/skyrim: Enable ASPM for SD
Enable ASPM for SD card reader to reduce power usage.
TEST=Boot to OS and verify ASPM is enabled via `lspci -s 02:00.0 -vvv | grep ASPM` BUG=b:243771794
Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Change-Id: I45a290c8ceddd39f65c6fe1390e3a753cad99899 --- M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/skyrim/port_descriptors.c 2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/67304/1
diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 03c9dfa..992a2e6 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -38,6 +38,7 @@ select SOC_AMD_MENDOCINO select SOC_AMD_COMMON_BLOCK_USE_ESPI select TPM_GOOGLE_TI50 + select PCIEXP_ASPM
config CHROMEOS select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index ac64259..e03d1d5 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -28,6 +28,8 @@ .function_number = PCI_FUNC(SD_DEVFN), .link_speed_capability = GEN3, .turn_off_unused_lanes = true, + .link_aspm = 2, + .link_hotplug = 3, .gpio_group_id = GPIO_27, .clk_req = CLK_REQ1, },