Change in coreboot[master]: arch/x86: Improve definition of MAYBE_STATIC

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34886 )

Change subject: arch/x86: Improve definition of MAYBE_STATIC
......................................................................

arch/x86: Improve definition of MAYBE_STATIC

With CAR_GLOBAL_MIGRATION=n .bss is always available
for zero-initialised variables in pre-ram stages.

Change-Id: I9f584058c7ea3a68ef7f38eaf3c9d8daf620828e
Signed-off-by: Kyösti Mälkki 
---
M src/include/stddef.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/34886/1

diff --git a/src/include/stddef.h b/src/include/stddef.h
index 7cae2e6..d7b6d60 100644
--- a/src/include/stddef.h
+++ b/src/include/stddef.h
@@ -36,7 +36,7 @@
 #endif

/* Work around non-writable data segment in execute-in-place romstage on x86. */
-#if defined(__PRE_RAM__) && CONFIG(ARCH_X86)
+#if defined(__PRE_RAM__) && CONFIG(CAR_GLOBAL_MIGRATION)
 #define MAYBE_STATIC
 #else
 #define MAYBE_STATIC static

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34886 )

Change subject: arch/x86: Improve definition of MAYBE_STATIC
......................................................................

Patch Set 1: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34886 )

Change subject: arch/x86: Improve definition of MAYBE_STATIC
......................................................................

Patch Set 1: Code-Review-2

Have to block this until AGESA is figured out too.

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34886 )

Change subject: arch/x86: Improve definition of MAYBE_STATIC
......................................................................

Patch Set 1:

src/mainboard/intel/icelake_rvp/board_id.c:     MAYBE_STATIC int id = -1;

Need some solution for these.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34886 )

Change subject: arch/x86: Improve definition of MAYBE_STATIC
......................................................................

Patch Set 1:
> Patch Set 1:
>
> src/mainboard/intel/icelake_rvp/board_id.c:     MAYBE_STATIC int id = -1;
>
> Need some solution for these.

Got it. OK. Looks like we may have to do zero vs non-zero decorations?

Change in coreboot[master]: arch/x86: Extend MAYBE_STATIC with MAYBE_BSS

[Kyösti Mälkki (Code Review)]

Hello Aaron Durbin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34886

to look at the new patch set (#2).

Change subject: arch/x86: Extend MAYBE_STATIC with MAYBE_BSS
......................................................................

arch/x86: Extend MAYBE_STATIC with MAYBE_BSS

With CAR_GLOBAL_MIGRATION=n .bss is always available
for zero-initialised variables in pre-ram stages.

Change-Id: I9f584058c7ea3a68ef7f38eaf3c9d8daf620828e
Signed-off-by: Kyösti Mälkki 
---
M src/device/device_const.c
M src/ec/google/chromeec/ec_lpc.c
M src/include/stddef.h
M src/lib/lzma.c
M src/lib/timestamp.c
M src/mainboard/google/stout/chromeos.c
M src/security/tpm/tspi/log.c
M src/soc/intel/baytrail/northcluster.c
M src/soc/intel/braswell/northcluster.c
9 files changed, 19 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/34886/2

Change in coreboot[master]: arch/x86: Extend MAYBE_STATIC with MAYBE_BSS

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34886 )

Change subject: arch/x86: Extend MAYBE_STATIC with MAYBE_BSS
......................................................................

Abandoned

squashed in CB:34939