Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31697 )
Change subject: arch/io.h: Add missing includes ......................................................................
arch/io.h: Add missing includes
Fixes indirect includes that would break with followup work.
Change-Id: I37ca01b904a0b422a4d09475377e755e167a6ab3 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/31697 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/include/cpu/amd/vr.h M src/mainboard/asus/kfsn4-dre/bootblock.c M src/mainboard/asus/p3b-f/romstage.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/hp/dl165_g6_fam10/bootblock.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t60/mainboard.c M src/mainboard/lenovo/z61t/mainboard.c M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c M src/northbridge/amd/amdfam10/setup_resource_map.c M src/northbridge/amd/amdmct/mct_ddr3/mport_d.c M src/northbridge/intel/pineview/romstage.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/denverton_ns/romstage.c M src/soc/intel/quark/reg_access.c M src/southbridge/amd/agesa/hudson/smihandler.c M src/southbridge/amd/pi/hudson/smihandler.c M src/southbridge/amd/sb700/smbus.c M src/southbridge/amd/sb800/smbus.c 21 files changed, 21 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/include/cpu/amd/vr.h b/src/include/cpu/amd/vr.h index 8c62e44..b5a1fe4 100644 --- a/src/include/cpu/amd/vr.h +++ b/src/include/cpu/amd/vr.h @@ -8,6 +8,7 @@ #define CPU_AMD_VR_H
#include <stdint.h> +#include <arch/io.h>
#define VRC_INDEX 0xAC1C // Index register #define VRC_DATA 0xAC1E // Data register diff --git a/src/mainboard/asus/kfsn4-dre/bootblock.c b/src/mainboard/asus/kfsn4-dre/bootblock.c index 454443f..ec8b2da 100644 --- a/src/mainboard/asus/kfsn4-dre/bootblock.c +++ b/src/mainboard/asus/kfsn4-dre/bootblock.c @@ -15,6 +15,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <pc80/mc146818rtc.h>
#include <superio/winbond/common/winbond.h> diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c index 4686fb5..387cecb 100644 --- a/src/mainboard/asus/p3b-f/romstage.c +++ b/src/mainboard/asus/p3b-f/romstage.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <device/pci_def.h> #include <console/console.h> #include <southbridge/intel/i82371eb/i82371eb.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index f11bde4..08fb73f 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -15,6 +15,7 @@
#include <baseboard/variants.h> #include <chip.h> +#include <arch/io.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> diff --git a/src/mainboard/hp/dl165_g6_fam10/bootblock.c b/src/mainboard/hp/dl165_g6_fam10/bootblock.c index e1e1a42..7a88566 100644 --- a/src/mainboard/hp/dl165_g6_fam10/bootblock.c +++ b/src/mainboard/hp/dl165_g6_fam10/bootblock.c @@ -11,6 +11,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <device/pnp_def.h>
#define SCH4307_CONFIG_PORT 0x162e diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c index 0777412..8a9fbf1 100644 --- a/src/mainboard/kontron/986lcd-m/romstage.c +++ b/src/mainboard/kontron/986lcd-m/romstage.c @@ -17,6 +17,7 @@
#include <stdint.h> #include <halt.h> +#include <arch/io.h> #include <console/console.h> #include <cpu/intel/romstage.h> #include <cpu/x86/bist.h> diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c index df1f174..2d998fb 100644 --- a/src/mainboard/lenovo/t60/mainboard.c +++ b/src/mainboard/lenovo/t60/mainboard.c @@ -16,6 +16,7 @@ */
#include <device/pci_def.h> +#include <arch/io.h> #include <device/device.h> #include <ec/lenovo/pmh7/pmh7.h> #include <ec/lenovo/h8/h8.h> diff --git a/src/mainboard/lenovo/z61t/mainboard.c b/src/mainboard/lenovo/z61t/mainboard.c index 6616b4a..886b4fb 100644 --- a/src/mainboard/lenovo/z61t/mainboard.c +++ b/src/mainboard/lenovo/z61t/mainboard.c @@ -16,6 +16,7 @@ */
#include <device/pci_def.h> +#include <arch/io.h> #include <device/device.h> #include <ec/lenovo/pmh7/pmh7.h> #include <ec/lenovo/h8/h8.h> diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c index c436b02..3e2e7f0 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <bootstate.h> #include <cf9_reset.h> #include <console/console.h> diff --git a/src/northbridge/amd/amdfam10/setup_resource_map.c b/src/northbridge/amd/amdfam10/setup_resource_map.c index 38475f3..de2eeac 100644 --- a/src/northbridge/amd/amdfam10/setup_resource_map.c +++ b/src/northbridge/amd/amdfam10/setup_resource_map.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <inttypes.h> #include <console/console.h> #include <device/pci_ops.h> diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mport_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mport_d.c index 76a63b5..3c512ed 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mport_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mport_d.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <inttypes.h> #include <string.h> #include "mct_d.h" diff --git a/src/northbridge/intel/pineview/romstage.c b/src/northbridge/intel/pineview/romstage.c index 0d2cc36..757e272 100644 --- a/src/northbridge/intel/pineview/romstage.c +++ b/src/northbridge/intel/pineview/romstage.c @@ -17,6 +17,7 @@ * so this one is named with prefix mainboard. */
+#include <arch/io.h> #include <lib.h> #include <timestamp.h> #include <console/console.h> diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c index 4854e52..657ff49 100644 --- a/src/soc/amd/stoneyridge/smihandler.c +++ b/src/soc/amd/stoneyridge/smihandler.c @@ -15,6 +15,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <cpu/x86/cache.h> diff --git a/src/soc/intel/braswell/lpc_init.c b/src/soc/intel/braswell/lpc_init.c index a593d30..12ee42c 100644 --- a/src/soc/intel/braswell/lpc_init.c +++ b/src/soc/intel/braswell/lpc_init.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <soc/gpio.h> #include <soc/pm.h> #include <soc/iomap.h> diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index 31bcc97..fc22577 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <device/device.h> #include <device/path.h> #include <device/smbus.h> diff --git a/src/soc/intel/denverton_ns/romstage.c b/src/soc/intel/denverton_ns/romstage.c index 5df8b71..73c8269 100644 --- a/src/soc/intel/denverton_ns/romstage.c +++ b/src/soc/intel/denverton_ns/romstage.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */
+#include <arch/io.h> #include <cbmem.h> #include <cf9_reset.h> #include <console/console.h> diff --git a/src/soc/intel/quark/reg_access.c b/src/soc/intel/quark/reg_access.c index 50a8ff0..df171f5 100644 --- a/src/soc/intel/quark/reg_access.c +++ b/src/soc/intel/quark/reg_access.c @@ -15,6 +15,7 @@
#define __SIMPLE_DEVICE__
+#include <arch/io.h> #include <assert.h> #include <cpu/x86/mtrr.h> #include <console/console.h> diff --git a/src/southbridge/amd/agesa/hudson/smihandler.c b/src/southbridge/amd/agesa/hudson/smihandler.c index 5ef9d6a..a87b75d 100644 --- a/src/southbridge/amd/agesa/hudson/smihandler.c +++ b/src/southbridge/amd/agesa/hudson/smihandler.c @@ -18,6 +18,7 @@ * SMI handler for Hudson southbridges */
+#include <arch/io.h> #include "hudson.h" #include "smi.h"
diff --git a/src/southbridge/amd/pi/hudson/smihandler.c b/src/southbridge/amd/pi/hudson/smihandler.c index 5ef9d6a..a87b75d 100644 --- a/src/southbridge/amd/pi/hudson/smihandler.c +++ b/src/southbridge/amd/pi/hudson/smihandler.c @@ -18,6 +18,7 @@ * SMI handler for Hudson southbridges */
+#include <arch/io.h> #include "hudson.h" #include "smi.h"
diff --git a/src/southbridge/amd/sb700/smbus.c b/src/southbridge/amd/sb700/smbus.c index 58bbe4c..9b0e8f9 100644 --- a/src/southbridge/amd/sb700/smbus.c +++ b/src/southbridge/amd/sb700/smbus.c @@ -16,6 +16,7 @@ #ifndef _SB700_SMBUS_C_ #define _SB700_SMBUS_C_
+#include <arch/io.h> #include "smbus.h"
extern uint8_t amd_sb700_aux_smbus; diff --git a/src/southbridge/amd/sb800/smbus.c b/src/southbridge/amd/sb800/smbus.c index 0803b12..fef6ab8 100644 --- a/src/southbridge/amd/sb800/smbus.c +++ b/src/southbridge/amd/sb800/smbus.c @@ -16,6 +16,7 @@ #ifndef _SB800_SMBUS_C_ #define _SB800_SMBUS_C_
+#include <arch/io.h> #include "smbus.h"
static int smbus_wait_until_ready(u32 smbus_io_base)
-
Patrick Georgi (Code Review)