Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54753 )
Change subject: cpu/x86/mp_init: Support both xapic and x2apic with common code
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Did not test yet, but looked reasonable. Can we add a CONFIG(X2APIC_SUPPORTED) to skip all those is_x2apic_mode() tests inside x86/lapic.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic402940e835d3e2216494740b2d069254eab457d
Gerrit-Change-Number: 54753
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 29 May 2021 17:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment