Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39118 )
Change subject: mb/google/hatch: reindent comment ......................................................................
mb/google/hatch: reindent comment
Change-Id: I8c721c7ccba4f87d4acb9dae74213a46151fe2ed Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/hatch/variants/puff/include/variant/ec.h 1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/39118/1
diff --git a/src/mainboard/google/hatch/variants/puff/include/variant/ec.h b/src/mainboard/google/hatch/variants/puff/include/variant/ec.h index 1283763..2c2e62d 100644 --- a/src/mainboard/google/hatch/variants/puff/include/variant/ec.h +++ b/src/mainboard/google/hatch/variants/puff/include/variant/ec.h @@ -54,11 +54,10 @@ /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE
-/** +/* * Defines EC wake pin route. - * Note that GPE_EC_WAKE is defined, confusingly, as - * GPE_LAN_WAK which is GPD2/LAN_WAKE# on the PCH or - * as the line EC_PCH_WAKE_ODL on the schematic. + * Note that GPE_EC_WAKE is defined, confusingly, as GPE_LAN_WAK which is GPD2/LAN_WAKE# + * on the PCH or as the line EC_PCH_WAKE_ODL on the schematic. */ #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39118 )
Change subject: mb/google/hatch: reindent comment ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39118/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39118/1//COMMIT_MSG@7 PS1, Line 7: reindent reflow? The indentation seems to be the same.
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39118
to look at the new patch set (#2).
Change subject: mb/google/hatch: reflow comment ......................................................................
mb/google/hatch: reflow comment
Change-Id: I8c721c7ccba4f87d4acb9dae74213a46151fe2ed Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/hatch/variants/puff/include/variant/ec.h 1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/39118/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39118 )
Change subject: mb/google/hatch: reflow comment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39118/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39118/1//COMMIT_MSG@7 PS1, Line 7: reindent
reflow? The indentation seems to be the same.
indeed.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39118 )
Change subject: mb/google/hatch: reflow comment ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39118 )
Change subject: mb/google/hatch: reflow comment ......................................................................
mb/google/hatch: reflow comment
Change-Id: I8c721c7ccba4f87d4acb9dae74213a46151fe2ed Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39118 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/hatch/variants/puff/include/variant/ec.h 1 file changed, 3 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/puff/include/variant/ec.h b/src/mainboard/google/hatch/variants/puff/include/variant/ec.h index 1283763..2c2e62d 100644 --- a/src/mainboard/google/hatch/variants/puff/include/variant/ec.h +++ b/src/mainboard/google/hatch/variants/puff/include/variant/ec.h @@ -54,11 +54,10 @@ /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE
-/** +/* * Defines EC wake pin route. - * Note that GPE_EC_WAKE is defined, confusingly, as - * GPE_LAN_WAK which is GPD2/LAN_WAKE# on the PCH or - * as the line EC_PCH_WAKE_ODL on the schematic. + * Note that GPE_EC_WAKE is defined, confusingly, as GPE_LAN_WAK which is GPD2/LAN_WAKE# + * on the PCH or as the line EC_PCH_WAKE_ODL on the schematic. */ #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39118 )
Change subject: mb/google/hatch: reflow comment ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/910 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/909 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/908
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)