Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84932?usp=email )
Change subject: mb/google/rauru: Configure TPM
......................................................................
Patch Set 13: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84932/comment/c03c5696_06b18305?usp... :
PS11, Line 9: Add TPM support
Which TPM is used?
Add Google Ti50 TPM support
https://review.coreboot.org/c/coreboot/+/84932/comment/82f68820_b035bc9b?usp... :
PS11, Line 14: TEST=build pass, boot ok and there is no CR50 TPM timeout log
Did you measure the frequency?
Of course. The factory also measured the signal in order the meet SI requirement.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84932/comment/78e07cf9_d87251a5?usp... :
PS13, Line 19: BUG=b:317009620
move to line 14
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84932?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I582f010a9033ccb1771dbb3ccab9f16314628796
Gerrit-Change-Number: 84932
Gerrit-PatchSet: 13
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 08 Nov 2024 13:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org