HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39991 )
Change subject: soc/intel: Remove unneeded whitespaces ......................................................................
soc/intel: Remove unneeded whitespaces
Change-Id: Ib156ebede1ee24a1c7bd20d01792ec80cba8f37d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/cannonlake/acpi/lpit.asl M src/soc/intel/common/acpi/platform.asl M src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/39991/1
diff --git a/src/soc/intel/cannonlake/acpi/lpit.asl b/src/soc/intel/cannonlake/acpi/lpit.asl index 6ae4975..0d2d9c3 100644 --- a/src/soc/intel/cannonlake/acpi/lpit.asl +++ b/src/soc/intel/cannonlake/acpi/lpit.asl @@ -78,7 +78,7 @@ /* * Save the current PM bits then * enable GPIO PM with MISCCFG_ENABLE_GPIO_PM_CONFIG - */ + */ If (CondRefOf (_SB.PCI0.EGPM)) { _SB.PCI0.EGPM () diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl index 8984f14..57f7505 100644 --- a/src/soc/intel/common/acpi/platform.asl +++ b/src/soc/intel/common/acpi/platform.asl @@ -43,7 +43,7 @@ /* * Save the current PM bits then * enable GPIO PM with MISCCFG_ENABLE_GPIO_PM_CONFIG - */ + */ If (CondRefOf (_SB.PCI0.EGPM)) { _SB.PCI0.EGPM () diff --git a/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl b/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl index b3278f5..ede2208 100644 --- a/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl +++ b/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl @@ -19,7 +19,7 @@ * The mapping fields ae Address, Pin, Source, Source Index. */
-#define GEN_PCIE_LEGACY_IRQ() \ +#define GEN_PCIE_LEGACY_IRQ() \ Package (0x04) { 0x0000FFFF, 0x00, LNKA, 0x00 }, \ Package (0x04) { 0x0001FFFF, 0x00, LNKA, 0x00 }, \ Package (0x04) { 0x0002FFFF, 0x00, LNKA, 0x00 }, \
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39991 )
Change subject: soc/intel: Remove unneeded whitespaces ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39991 )
Change subject: soc/intel: Remove unneeded whitespaces ......................................................................
soc/intel: Remove unneeded whitespaces
Change-Id: Ib156ebede1ee24a1c7bd20d01792ec80cba8f37d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39991 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/cannonlake/acpi/lpit.asl M src/soc/intel/common/acpi/platform.asl M src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi/lpit.asl b/src/soc/intel/cannonlake/acpi/lpit.asl index 6ae4975..0d2d9c3 100644 --- a/src/soc/intel/cannonlake/acpi/lpit.asl +++ b/src/soc/intel/cannonlake/acpi/lpit.asl @@ -78,7 +78,7 @@ /* * Save the current PM bits then * enable GPIO PM with MISCCFG_ENABLE_GPIO_PM_CONFIG - */ + */ If (CondRefOf (_SB.PCI0.EGPM)) { _SB.PCI0.EGPM () diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl index 6ec2ac9..338e681 100644 --- a/src/soc/intel/common/acpi/platform.asl +++ b/src/soc/intel/common/acpi/platform.asl @@ -32,7 +32,7 @@ /* * Save the current PM bits then * enable GPIO PM with MISCCFG_ENABLE_GPIO_PM_CONFIG - */ + */ If (CondRefOf (_SB.PCI0.EGPM)) { _SB.PCI0.EGPM () diff --git a/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl b/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl index b3278f5..ede2208 100644 --- a/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl +++ b/src/soc/intel/xeon_sp/skx/acpi/uncore_irq.asl @@ -19,7 +19,7 @@ * The mapping fields ae Address, Pin, Source, Source Index. */
-#define GEN_PCIE_LEGACY_IRQ() \ +#define GEN_PCIE_LEGACY_IRQ() \ Package (0x04) { 0x0000FFFF, 0x00, LNKA, 0x00 }, \ Package (0x04) { 0x0001FFFF, 0x00, LNKA, 0x00 }, \ Package (0x04) { 0x0002FFFF, 0x00, LNKA, 0x00 }, \
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39991 )
Change subject: soc/intel: Remove unneeded whitespaces ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2204 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2203 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2202
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)