Attention is currently required from: Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Shuo Liu.
Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/85104?usp=email )
Change subject: cpu/x86/mtrr: Use fls/ffs from lib.h
......................................................................
Patch Set 5:
(1 comment)
File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/c/coreboot/+/85104/comment/87620597_11186cb6?usp... :
PS5, Line 80: #include <lib.h>
nit: I know this is not an official rule but most of the time but the inclusion follows the alphabet […]
I would agree with this but there's other includes at the beginning of the file and none of them are sorted alphabetically. I don't think this change makes it worse, and I wouldn't mind if someone consolidated the includes at the start of the file.
Actually, this change *is* consistent with the existing *reverse* alphabetical order in the file :^)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85104?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9c6f1027447b04627d7f21d777cbea142588093
Gerrit-Change-Number: 85104
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Nov 2024 17:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com