Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46470 )
Change subject: soc/intel/common/acpi: rename LPID to PEPD ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46470/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46470/4//COMMIT_MSG@7 PS4, Line 7: PEPD Can we instead rename this to PMCD? PEPD is something very Windows-specific and I see it being used in Intel documents specific to Windows only.
On the other hand, both Microsoft documentation(https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/device-man...) and Linux kernel(https://github.com/torvalds/linux/blob/master/drivers/acpi/sleep.c#L691) refer to this class of devices as "System Power Management Controller".
I think it would be good to use the same in coreboot as well? i.e. PMCD - Power Management Controller Device.
https://review.coreboot.org/c/coreboot/+/46470/4/src/soc/intel/common/acpi/l... File src/soc/intel/common/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/46470/4/src/soc/intel/common/acpi/l... PS4, Line 3: PEPD_DSM_ARG2_ENUM_FUNCTIONS I think it would be good to have LPI(Low Power Idle) in the name to make it clear that it is specific to Low Power S0 Idle. I think we can drop ARG2 since that is not really helpful.
PMCD_DSM_LPI_ENUM_FUNCTIONS PMCD_DSM_LPI_GET_DEVICE_CONSTRAINTS and so on
-
Furquan Shaikh (Code Review)