Attention is currently required from: Shelley Chen, Ravi Kumar Bokka, Sudheer Amrabadi.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64245 )
Change subject: qclib common code clean up changes
......................................................................
Patch Set 9: Code-Review+2
(2 comments)
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/64245/comment/ce3c1414_c47596d7
PS2, Line 77: // suggestions on what to do here?
Actually, you never fixed this either. […]
Ack
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/64245/comment/ca2a8e11_568285c5
PS8, Line 82: const char *qclib_file(enum qclib_cbfs_file file) __attribute__((weak, alias("qclib_file_default")));
Applied this but looks hitting with checkpatch warnings, can you please review this once please.
That's fine, those are about Linux macros that coreboot doesn't have, so you can ignore them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I211e132d1728cf14bdd201b71618af89b339cbc1
Gerrit-Change-Number: 64245
Gerrit-PatchSet: 9
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: mturney mturney
quic_mturney@quicinc.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Tue, 31 May 2022 22:04:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-MessageType: comment