Attention is currently required from: Shelley Chen, Ravi Kumar Bokka, Sudheer Amrabadi.

Patch set 9:Code-Review +2

View Change

2 comments:

• File src/soc/qualcomm/common/qclib.c:

  • Patch Set #2, Line 77: // suggestions on what to do here?

    Actually, you never fixed this either. […]

    Ack

• File src/soc/qualcomm/common/qclib.c:

  • Patch Set #8, Line 82: const char *qclib_file(enum qclib_cbfs_file file) __attribute__((weak, alias("qclib_file_default")));

    Applied this but looks hitting with checkpatch warnings, can you please review this once please.

    That's fine, those are about Linux macros that coreboot doesn't have, so you can ignore them.

To view, visit change 64245. To unsubscribe, or for help writing mail filters, visit settings.