Change in coreboot[master]: mb/google/dedede: Enable SIS touch screen for Waddledoo

[Dtrain Hsu (Code Review)]

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable SIS touch screen for Waddledoo

Add SiS9813  USI touchsreen support.

BUG=b:152936541
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
---
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
2 files changed, 25 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40250/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c
index bdc3de4..56e33d9 100644
--- a/src/mainboard/google/dedede/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c
@@ -29,7 +29,7 @@
    /* A10 : WWAN_EN */
    PAD_NC(GPP_A10, NONE),
    /* A11 : TOUCH_RPT_EN */
-	PAD_NC(GPP_A11, NONE),
+	PAD_CFG_GPO(GPP_A11, 0, DEEP),
    /* A12 : USB_OC1_N */
    PAD_NC(GPP_A12, NONE),
    /* A13 : USB_OC2_N */
@@ -154,11 +154,11 @@
    /* D3  : WLAN_PCIE_WAKE_ODL */
    PAD_CFG_GPI_SCI_LOW(GPP_D3, NONE, DEEP, EDGE_SINGLE),
    /* D4  : TOUCH_INT_ODL */
-	PAD_NC(GPP_D4, NONE),
+	PAD_CFG_GPI_APIC(GPP_D4, NONE, PLTRST, LEVEL, INVERT),
    /* D5  : TOUCH_RESET_L */
-	PAD_NC(GPP_D5, NONE),
+	PAD_CFG_GPO(GPP_D5, 0, DEEP),
    /* D6  : EN_PP3300_TOUCH_S0 */
-	PAD_NC(GPP_D6, NONE),
+	PAD_CFG_GPO(GPP_D6, 0, DEEP),
    /* D7  : EMR_INT_ODL */
    PAD_NC(GPP_D7, NONE),
    /* D8  : GPP_D8/GSPI2_CS0B/UART0A_RXD */
diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index 884199c..3f138e4 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -55,6 +55,27 @@
    			device i2c 15 on end
    		end
    	end #I2C 0
+		device pci 15.2 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""SIS6496""
+				register "generic.desc" = ""SIS Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+				register "generic.reset_delay_ms" = "100"
+				register "generic.reset_off_delay_ms" = "5"
+				register "generic.stop_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
+				register "generic.stop_delay_ms" = "100"
+				register "generic.enable_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+				register "generic.enable_delay_ms" = "5"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x00"
+				device i2c 5c on end
+			end
+		end # I2C 2
    	device pci 1c.7 on
    		chip drivers/intel/wifi
    			register "wake" = "GPE0_DW2_03"

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40250

to look at the new patch set (#2).

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable SIS touch screen for Waddledoo

Add SiS9813 USI touchsreen support.

BUG=b:152936541
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
---
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
2 files changed, 25 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40250/2

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... 
PS2, Line 70: 				register "generic.stop_delay_ms" = "100"
Do we need the stop pin for SiS? And if yes, what pin of SiS will be connected since I don't see this info in the spec? Thanks.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40250/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40250/2//COMMIT_MSG@9 
PS2, Line 9: touchsreen
touchscreen

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40250

to look at the new patch set (#3).

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable SIS touch screen for Waddledoo

Add SiS9813 USI touchscreen support.

BUG=b:152936541
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
---
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
2 files changed, 25 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40250/3

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40250/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40250/2//COMMIT_MSG@9 
PS2, Line 9: touchsreen
> touchscreen

Done

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40250

to look at the new patch set (#4).

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable SIS touch screen for Waddledoo

Add SiS9813 USI touchscreen support.

BUG=b:152936541
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
---
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
2 files changed, 23 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40250/4

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 4: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
PS4, Line 68: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
It seems SiS does not support stop/report GPIO. No need to configure stop_gpio in that case. Marco already had a comment regarding that.

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... 
PS2, Line 70: 				register "generic.stop_delay_ms" = "100"
> Do we need the stop pin for SiS? And if yes, what pin of SiS will be connected since I don't see thi […]

Do we want to wait the new datasheet from SiS? b/152936541#comment20

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
PS4, Line 68: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
> It seems SiS does not support stop/report GPIO. No need to configure stop_gpio in that case. […]

Do we want to wait the new datasheet from SiS? b/152936541#comment20

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touch screen for Waddledoo
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
PS4, Line 68: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
> Do we want to wait the new datasheet from SiS? b/152936541#comment20

Let us wait first and please ask SiS to update. Thanks.

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledoo

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Karthik Ramasubramanian, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40250

to look at the new patch set (#6).

Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledoo
......................................................................

mb/google/dedede: Enable SIS touchscreen for Waddledoo

Add SiS9813 USI touchscreen support.

BUG=b:152936541
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
---
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
2 files changed, 23 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/40250/6

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledoo

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledoo
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
PS4, Line 68: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
> Let us wait first and please ask SiS to update. Thanks.

SiS updated in b/152936541#comment21

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledoo

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledoo
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/2/src/mainboard/google/dedede... 
PS2, Line 70: 				register "generic.stop_delay_ms" = "100"
> Do we want to wait the new datasheet from SiS? b/152936541#comment20

Done

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40250/4/src/mainboard/google/dedede... 
PS4, Line 68: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
> SiS updated in b/152936541#comment21

Done

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledoo

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledoo
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledoo

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledoo
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledoo

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40250 )

Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledoo
......................................................................

mb/google/dedede: Enable SIS touchscreen for Waddledoo

Add SiS9813 USI touchscreen support.

BUG=b:152936541
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: Id04c46c763fdf68418bf2e97be4c8bb6bb73c749
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40250
Reviewed-by: Marco Chen 
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: EricR Lai 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
2 files changed, 23 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marco Chen: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  EricR Lai: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c
index 89683bd..d12d2c4 100644
--- a/src/mainboard/google/dedede/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c
@@ -29,7 +29,7 @@
    /* A10 : WWAN_EN */
    PAD_NC(GPP_A10, NONE),
    /* A11 : TOUCH_RPT_EN */
-	PAD_NC(GPP_A11, NONE),
+	PAD_CFG_GPO(GPP_A11, 0, DEEP),
    /* A12 : USB_OC1_N */
    PAD_NC(GPP_A12, NONE),
    /* A13 : USB_OC2_N */
@@ -154,11 +154,11 @@
    /* D3  : WLAN_PCIE_WAKE_ODL */
    PAD_CFG_GPI_SCI_LOW(GPP_D3, NONE, DEEP, EDGE_SINGLE),
    /* D4  : TOUCH_INT_ODL */
-	PAD_NC(GPP_D4, NONE),
+	PAD_CFG_GPI_APIC(GPP_D4, NONE, PLTRST, LEVEL, INVERT),
    /* D5  : TOUCH_RESET_L */
-	PAD_NC(GPP_D5, NONE),
+	PAD_CFG_GPO(GPP_D5, 0, DEEP),
    /* D6  : EN_PP3300_TOUCH_S0 */
-	PAD_NC(GPP_D6, NONE),
+	PAD_CFG_GPO(GPP_D6, 0, DEEP),
    /* D7  : EMR_INT_ODL */
    PAD_NC(GPP_D7, NONE),
    /* D8  : GPP_D8/GSPI2_CS0B/UART0A_RXD */
diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index cb21c63..cc9e651 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -55,6 +55,25 @@
    			device i2c 15 on end
    		end
    	end #I2C 0
+		device pci 15.2 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""SIS6496""
+				register "generic.desc" = ""SIS Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+				register "generic.reset_delay_ms" = "100"
+				register "generic.stop_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
+				register "generic.enable_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+				register "generic.enable_delay_ms" = "7"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x00"
+				device i2c 5c on end
+			end
+		end # I2C 2
    	device pci 1c.7 on
    		chip drivers/intel/wifi
    			register "wake" = "GPE0_DW2_03"