Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26115 )
Change subject: binaryPI: Fix cache coherency use for AP CPUs
......................................................................
Patch Set 8: Code-Review+1
Although still cbmem utility reports:
*** Pre-CBMEM romstage console overflowed, log truncated! ***
Is there not enough "space" during CAR to store the whole log? Tried setting cbmem console area size to 256KiB, but it seems not to be the case.
You need to adapt `PRERAM_CBMEM_CONSOLE_SIZE` as far as I know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4abcec90c03046e32dafcf97d2f7228ca93c5549
Gerrit-Change-Number: 26115
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Feb 2019 13:25:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment