Change in coreboot[master]: mb/purism/librem_mini: Drop community comments in GPIO config
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
mb/purism/librem_mini: Drop community comments in GPIO config
These add nothing useful to the GPIO config
Change-Id: Ieecc9bd67d020e141c3a1f1d387034df5e563068 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47190/1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c index 254510e..04c8614 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c @@ -5,8 +5,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = {
- /* ------- GPIO Community 0 ------- */ - /* ------- GPIO Group GPP_A ------- */
/* GPP_A0 - RCIN# */ @@ -237,8 +235,6 @@ /* DW0: 0x44000300, DW1: 0x00001000 */ PAD_NC(GPP_G7, DN_20K),
- /* ------- GPIO Community 1 ------- */ - /* ------- GPIO Group GPP_D ------- */
/* GPP_D0 - GPIO */ @@ -533,8 +529,6 @@ /* DW0: 0x44000200, DW1: 0x00000000 */ PAD_CFG_GPO(GPP_H23, 0, DEEP),
- /* ------- GPIO Community 2 ------- */ - /* ------- GPIO Group GPD ------- */
/* GPD0 - BATLOW# */ @@ -585,8 +579,6 @@ /* DW0: 0x04000600, DW1: 0x00000000 */ PAD_CFG_NF(GPD11, NONE, RSMRST, NF1),
- /* ------- GPIO Community 4 ------- */ - /* ------- GPIO Group GPP_C ------- */
/* GPP_C0 - SMBCLK */
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem... PS1, Line 231: /* DW0: 0x44000300, DW1: 0x00000000 */ these could be dropped, too. I guess you checked the macros by looking at the datasheet?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem... PS1, Line 231: /* DW0: 0x44000300, DW1: 0x00000000 */
these could be dropped, too. […]
the macros were generated by intelp2m, I spot checked the output but didn't verify each and every pad config
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47190
to look at the new patch set (#2).
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
mb/purism/librem_mini: Drop community comments in GPIO config
These add nothing useful to the GPIO config
Change-Id: Ieecc9bd67d020e141c3a1f1d387034df5e563068 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47190/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem... PS1, Line 231: /* DW0: 0x44000300, DW1: 0x00000000 */
the macros were generated by intelp2m, I spot checked the output but didn't verify each and every pa […]
Done
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config ......................................................................
mb/purism/librem_mini: Drop community comments in GPIO config
These add nothing useful to the GPIO config
Change-Id: Ieecc9bd67d020e141c3a1f1d387034df5e563068 Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/47190 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c index 3a48dc5..283d646 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c @@ -5,8 +5,6 @@ /* Pad configuration was generated automatically using intelp2m utility */ static const struct pad_config gpio_table[] = {
- /* ------- GPIO Community 0 ------- */ - /* ------- GPIO Group GPP_A ------- */
/* GPP_A0 - RCIN# */ @@ -237,8 +235,6 @@ /* DW0: 0x44000300, DW1: 0x00001000 */ PAD_NC(GPP_G7, DN_20K),
- /* ------- GPIO Community 1 ------- */ - /* ------- GPIO Group GPP_D ------- */
/* GPP_D0 - GPIO */ @@ -533,8 +529,6 @@ /* DW0: 0x44000200, DW1: 0x00000000 */ PAD_CFG_GPO(GPP_H23, 0, DEEP),
- /* ------- GPIO Community 2 ------- */ - /* ------- GPIO Group GPD ------- */
/* GPD0 - BATLOW# */ @@ -585,8 +579,6 @@ /* DW0: 0x44000600, DW1: 0x00000000 */ PAD_CFG_NF(GPD11, NONE, DEEP, NF1),
- /* ------- GPIO Community 4 ------- */ - /* ------- GPIO Group GPP_C ------- */
/* GPP_C0 - SMBCLK */
-
Matt DeVillier (Code Review) -
Michael Niewöhner (Code Review)