Change in coreboot[master]: mb/google/brya/var/nereid: Configure descriptor for either Type-C or ...
Attention is currently required from: Reka Norman, Paul Menzel, Tim Wawrzynczak. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63366 )
Change subject: mb/google/brya/var/nereid: Configure descriptor for either Type-C or HDMI ......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63366/comment/af09fd28_ed642761 PS8, Line 7: /
and (or remove the spaces around the slash)
Done
https://review.coreboot.org/c/coreboot/+/63366/comment/70a87a45_184eba25 PS8, Line 7: Type-C / HDMI
Or: either Type-C or HDMI
Done
https://review.coreboot.org/c/coreboot/+/63366/comment/6902f928_abe0b617 PS8, Line 17: HDMI: TypeCPort2Config = "DP Fixed Connection"
Which of the two works by default?
Not sure if I understand what you mean. Currently we have it set to "No Thunderbolt" by default. But that's arbitrary, we could have chosen either one.
File src/mainboard/google/brya/variants/nereid/variant.c:
https://review.coreboot.org/c/coreboot/+/63366/comment/fbbabdaf_12c85182 PS8, Line 36: BIOS_DEBUG
Could be info?
Done
-
Reka Norman (Code Review)