Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 81:
(8 comments)
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/32734/68//COMMIT_MSG@30 PS68, Line 30:
Does ACPI S3 work?
Done
https://review.coreboot.org/c/coreboot/+/32734/68/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/32734/68/Documentation/mainboard/su... PS68, Line 29: - MP init causes secondary APs to crash (fix in gerrit).
Mention the Change-Ids/URLs here?
Done
https://review.coreboot.org/c/coreboot/+/32734/22/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/Kconfig:
PS22:
I think it's useful to configure these options since they are needed sooner or later. […]
Done
https://review.coreboot.org/c/coreboot/+/32734/22/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/32734/22/src/mainboard/supermicro/x... PS22, Line 2: bool "X11SSH+-TF"
Is the `+` in the model name for this variant? My regular X11SSH-F (no T) does not have it.
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/gpio.h:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... PS68, Line 31: static const struct pad_config gpio_table[] = {
Unfortunately there is no board documentation / schematics publicly available
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... PS68, Line 210: device pci 01.1 on
@Angel Pons, thank you for the clarification. […]
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... PS68, Line 211: 4X
According to MNL-1783, SLOT6 is x8 electrical.
Done
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x... PS68, Line 236: device pnp 2e.0 on
please add a comment to this line to make clear what it does
Done
-
Philipp Deppenwiese (Code Review)