Change in coreboot[master]: src/mainboard/prodrive/hermes/variants/baseboard: add support for sat...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jonas Löffelholz (Code Review)

25 Jun 2020 25 Jun '20

1:01 p.m.

Jonas Löffelholz has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap ......................................................................

src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap

Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Signed-off-by: Jonas Loeffelholz Jonas.Loeffelholz@9elements.com --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42804/1

diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index 3388239..c4be117 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -19,6 +19,15 @@ register "SataPortsEnable[6]" = "1" register "SataPortsEnable[7]" = "1"

+ register "SataPortsHotPlug[0]" = "1" + register "SataPortsHotPlug[1]" = "1" + register "SataPortsHotPlug[2]" = "1" + register "SataPortsHotPlug[3]" = "1" + register "SataPortsHotPlug[4]" = "1" + register "SataPortsHotPlug[5]" = "1" + register "SataPortsHotPlug[6]" = "1" + register "SataPortsHotPlug[7]" = "1" + register "PchHdaDspEnable" = "0" register "PchHdaAudioLinkHda" = "1"

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Christian Walter (Code Review)

25 Jun 25 Jun

1:21 p.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap ......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap too much characters per line

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: src/ remove

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... PS1, Line 24: register "SataPortsHotPlug[2]" = "1" only enable hot plug on enabled sata ports

Patrick Rudolph (Code Review)

26 Jun 26 Jun

5:37 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: mainboard mainboard/ can be shortened to mb/

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@8 PS1, Line 8: Missing commit message. Describe what is being done and why

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 1 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Christian Walter christian.walter@9elements.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jun 2020 05:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jonas Löffelholz (Code Review)

30 Jun 30 Jun

7:52 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42804

to look at the new patch set (#2).

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Configure sataHotPlug in devicetree, as this functionality is now available for this soc.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42804/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 2 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Christian Walter christian.walter@9elements.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jonas Löffelholz (Code Review)

7:53 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Jonas Löffelholz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

Patch Set 2:

(5 comments)

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: src/

...

remove

Done

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: mainboard

...

mainboard/ can be shortened to mb/

Done

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/prodrive/hermes/variants/baseboard: add support for sata hotswap

...

too much characters per line

Done

https://review.coreboot.org/c/coreboot/+/42804/1//COMMIT_MSG@8 PS1, Line 8:

...

Missing commit message. […]

Done

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... PS1, Line 24: register "SataPortsHotPlug[2]" = "1"

...

only enable hot plug on enabled sata ports

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 2 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Christian Walter christian.walter@9elements.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 07:53:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Walter christian.walter@9elements.com Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Christian Walter (Code Review)

7:54 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... PS1, Line 24: register "SataPortsHotPlug[2]" = "1"

...

Done

no?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 2 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Christian Walter christian.walter@9elements.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 07:54:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonas Löffelholz Comment-In-Reply-To: Christian Walter christian.walter@9elements.com Gerrit-MessageType: comment

Jonas Löffelholz (Code Review)

8:09 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42804

to look at the new patch set (#3).

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Configure sataHotPlug in devicetree, as this functionality is now available for this soc.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/42804/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 3 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Christian Walter christian.walter@9elements.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jonas Löffelholz (Code Review)

8:12 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Jonas Löffelholz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42804/1/src/mainboard/prodrive/herm... PS1, Line 24: register "SataPortsHotPlug[2]" = "1"

...

no?

oops, but now it is.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 3 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Christian Walter christian.walter@9elements.com Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 08:12:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonas Löffelholz Comment-In-Reply-To: Christian Walter christian.walter@9elements.com Gerrit-MessageType: comment

Christian Walter (Code Review)

8:25 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 3 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 30 Jun 2020 08:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 Jul 1 Jul

5:22 a.m.

New subject: Change in coreboot[master]: mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42804 )

Change subject: mb/prodrive/hermes/variants/baseboard: configure sataHotplug ......................................................................

mb/prodrive/hermes/variants/baseboard: configure sataHotplug

Configure sataHotPlug in devicetree, as this functionality is now available for this soc.

Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Signed-off-by: Jonas Loeffelholz Jonas.Loeffelholz@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42804 Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Christian Walter: Looks good to me, approved

diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb index a56096e..6c6fe2d 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb +++ b/src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb @@ -19,6 +19,15 @@ register "SataPortsEnable[6]" = "1" register "SataPortsEnable[7]" = "1"

+ register "SataPortsHotPlug[0]" = "1" + register "SataPortsHotPlug[1]" = "1" + register "SataPortsHotPlug[2]" = "0" + register "SataPortsHotPlug[3]" = "0" + register "SataPortsHotPlug[4]" = "1" + register "SataPortsHotPlug[5]" = "1" + register "SataPortsHotPlug[6]" = "1" + register "SataPortsHotPlug[7]" = "1" + register "PchHdaDspEnable" = "0" register "PchHdaAudioLinkHda" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/42804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If462e33d1bbef8036d598970fb2774d0fda1fbb1 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 4 Gerrit-Owner: Jonas Löffelholz Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1636

days inactive

1642

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Christian Walter (Code Review)
Jonas Löffelholz (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)