Attention is currently required from: Shelley Chen, Tarun Tuli, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73211 )
Change subject: mb/google/poppy: Add support for variant SKU romstage GPIO configs
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/poppy/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/73211/comment/88b99a52_58f81e59
PS7, Line 392:
please drop one extra line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73211
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I593a23951306908fadc00e6bc8d9d310f09c5e4b
Gerrit-Change-Number: 73211
Gerrit-PatchSet: 7
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 14:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment