Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37786 )
Change subject: vboot: remove 2lib headers from Makefile ......................................................................
vboot: remove 2lib headers from Makefile
Only headers from firmware/lib should be imported. As far as I can tell, nothing imports 2lib headers directly anymore, so we can get rid of this CFLAG.
BUG=b:124141368, chromium:968464 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie5f3fe1d0180113b332e57ed07d4cfe563e7ecf2 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/37786/1
diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 5292bd1..8052549 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -123,8 +123,6 @@
endef # vboot-for-stage
-CFLAGS_common += -I3rdparty/vboot/firmware/2lib/include - $(eval $(call vboot-for-stage,bootblock)) $(eval $(call vboot-for-stage,romstage)) $(eval $(call vboot-for-stage,ramstage))
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37786 )
Change subject: vboot: remove 2lib headers from Makefile ......................................................................
Patch Set 1: Code-Review+2
Joel Kitching has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37786 )
Change subject: vboot: remove 2lib headers from Makefile ......................................................................
vboot: remove 2lib headers from Makefile
Only headers from firmware/lib should be imported. As far as I can tell, nothing imports 2lib headers directly anymore, so we can get rid of this CFLAG.
BUG=b:124141368, chromium:968464 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ie5f3fe1d0180113b332e57ed07d4cfe563e7ecf2 Signed-off-by: Joel Kitching kitching@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37786 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/security/vboot/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 5292bd1..8052549 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -123,8 +123,6 @@
endef # vboot-for-stage
-CFLAGS_common += -I3rdparty/vboot/firmware/2lib/include - $(eval $(call vboot-for-stage,bootblock)) $(eval $(call vboot-for-stage,romstage)) $(eval $(call vboot-for-stage,ramstage))
-
Aaron Durbin (Code Review) -
Joel Kitching (Code Review)