Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61459 )
Change subject: soc/intel/common: Define enum cpu_type type for core types
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/61459/comment/6ca5f62e_403d47ae
PS3, Line 14: cpu_type
Hm, there is already an […]
correct, how about enum cpu_perf_eff_type?
https://review.coreboot.org/c/coreboot/+/61459/comment/65e3a398_028c79d2
PS3, Line 94: if (global_cpu_type[core_id])
`if (global_cpu_type[core_id] == CPU_TYPE_BIG)`
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I740984a437da9d0518652f43180faf9b6ed4255e
Gerrit-Change-Number: 61459
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Feb 2022 18:01:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment