Attention is currently required from: Jonathan Zhang. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55005 )
Change subject: mb/ocp/deltalake: Add BIOS checksum value to SMBIOS ......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/55005/comment/c78476fc_07ab7484 PS2, Line 7: mb/ocp/deltalake: Add BIOS checksum value to SMBIOS
Another approach is to do this in build process: […]
The first approach can work w/o chicken and egg problem as long as the data for checksum calculation doesn't include VPD region. At build time cbfstool can extract and calculate several cbfs files' checksum from the coreboot image and set to VPD, and which later got populated into SMBIOS. On the machine we can use flashrom to read out the ifd bios region and does the same thing. For example flashrom read the bios into /tmp/bios.bin, then cbfstool /tmp/bios.bin extract -r COREBOOT -m x86 -n bootblock -f bootblock.bin cbfstool /tmp/bios.bin extract -r COREBOOT -m x86 -n fallback/romstage -f romstage.bin cbfstool /tmp/bios.bin extract -r COREBOOT -m x86 -n fallback/ramstage -f ramstage.bin cbfstool /tmp/bios.bin extract -r COREBOOT -m x86 -n fallback/payload -f payload.bin cat bootblock.bin romstage.bin ramstage.bin payload.bin > bios.bin md5sum bios.bin I just tested this works but somehow cbfstool needs to use the same version otherwise the read cbfs file can be different. The only drawback is that the VPD data can be tampered if we don't have lock protection, but which I guess is not a concern.
-
Johnny Lin (Code Review)