Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 7:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/7b48b4fa_b015f4c2 PS7, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/0b89e009_431e58de PS7, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/a194d803_7a3af5ba PS7, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/ed6d31e9_de875f1c PS7, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/b49e2967_a8a9e5c2 PS7, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/6541efdb_32144d68 PS7, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/8892a502_5fe73771 PS7, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/a8e60054_5d061203 PS7, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/5e47e11a_47c8c7c5 PS7, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/5d600812_344b649b PS7, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/14939b50_6439c672 PS7, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/92da1997_ddc95d76 PS7, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/7be875e2_2e5e2a41 PS7, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/3b096f14_929ae477 PS7, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119442): https://review.coreboot.org/c/coreboot/+/52662/comment/094c17e4_de22ca6e PS7, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)