Change in coreboot[master]: payloads/external/Makefile.inc: Fix regressions

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

20 Nov 2020 20 Nov '20

6:29 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47814 )

Change subject: payloads/external/Makefile.inc: Fix regressions ......................................................................

payloads/external/Makefile.inc: Fix regressions

Fixes: 14ca7407196 (Makefile.inc: Move adding SeaBIOS cbfs config files)

Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M payloads/external/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/47814/1

diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 6208578..0300581 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -121,14 +121,14 @@ INTERMEDIATE+=seabios_sercon seabios_sercon: $(obj)/coreboot.pre $(CBFSTOOL) @printf " SeaBIOS Add sercon-port file\n" -# $(CBFSTOOL) $@.tmp add-int -i $(CONFIG_SEABIOS_SERCON_PORT_ADDR) -n etc/sercon-port + $(CBFSTOOL) $< add-int -i $(CONFIG_SEABIOS_SERCON_PORT_ADDR) -n etc/sercon-port endif

ifeq ($(CONFIG_SEABIOS_THREAD_OPTIONROMS),y) INTERMEDIATE+=seabios_thread_optionroms seabios_thread_optionroms: $(obj)/coreboot.pre $(CBFSTOOL) @printf " SeaBIOS Thread optionroms\n" - $(CBFSTOOL) $@.tmp add-int -i 2 -n etc/threads + $(CBFSTOOL) $< add-int -i 2 -n etc/threads endif

# Depthcharge

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Nico Huber (Code Review)

20 Nov 20 Nov

6:32 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47814 )

Change subject: payloads/external/Makefile.inc: Fix regressions ......................................................................

Patch Set 1: Code-Review+2

(3 comments)

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG@7 PS1, Line 7: Fix regressions A bit more specific would be nice (the file contains lots of things). e.g. `Fix SeaBIOS option regressions`

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG@9 PS1, Line 9: 14ca7407196 `commit 14c...` to make it link in Gerrit.

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG@9 PS1, Line 9: Fixes: 14ca7407196 (Makefile.inc: Move adding SeaBIOS cbfs config files) Tested?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Gerrit-Change-Number: 47814 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Fri, 20 Nov 2020 17:32:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

6:41 p.m.

New subject: Change in coreboot[master]: payloads/external/Makefile.inc: Fix SeaBIOS option regressions

Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47814

to look at the new patch set (#2).

Change subject: payloads/external/Makefile.inc: Fix SeaBIOS option regressions ......................................................................

payloads/external/Makefile.inc: Fix SeaBIOS option regressions

Commit 14ca7407196 (Makefile.inc: Move adding SeaBIOS cbfs config files) introduced various regressions that were not spotted during review.

TEST=Building with SEABIOS_THREAD_OPTIONROMS is working properly again.

Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M payloads/external/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/47814/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Gerrit-Change-Number: 47814 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

6:42 p.m.

New subject: Change in coreboot[master]: payloads/external/Makefile.inc: Fix SeaBIOS option regressions

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47814 )

Change subject: payloads/external/Makefile.inc: Fix SeaBIOS option regressions ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG@7 PS1, Line 7: Fix regressions

...

A bit more specific would be nice (the file contains lots of things). e.g. […]

Done

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG@9 PS1, Line 9: 14ca7407196

...

`commit 14c...` to make it link in Gerrit.

Done (though I had to make it into a sentence)

https://review.coreboot.org/c/coreboot/+/47814/1//COMMIT_MSG@9 PS1, Line 9: Fixes: 14ca7407196 (Makefile.inc: Move adding SeaBIOS cbfs config files)

...

Tested?

Updated as per IRC

-- To view, visit https://review.coreboot.org/c/coreboot/+/47814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Gerrit-Change-Number: 47814 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Nov 2020 17:42:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Arthur Heymans (Code Review)

9:54 p.m.

New subject: Change in coreboot[master]: payloads/external/Makefile.inc: Fix SeaBIOS option regressions

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47814 )

Change subject: payloads/external/Makefile.inc: Fix SeaBIOS option regressions ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Gerrit-Change-Number: 47814 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Nov 2020 20:54:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

22 Nov 22 Nov

11:18 p.m.

New subject: Change in coreboot[master]: payloads/external/Makefile.inc: Fix SeaBIOS option regressions

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47814 )

Change subject: payloads/external/Makefile.inc: Fix SeaBIOS option regressions ......................................................................

payloads/external/Makefile.inc: Fix SeaBIOS option regressions

Commit 14ca7407196 (Makefile.inc: Move adding SeaBIOS cbfs config files) introduced various regressions that were not spotted during review.

TEST=Building with SEABIOS_THREAD_OPTIONROMS is working properly again.

Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47814 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/external/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved

# Depthcharge

-- To view, visit https://review.coreboot.org/c/coreboot/+/47814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4de0b11747e3df8dd31a85160add129d8cc6bd8a Gerrit-Change-Number: 47814 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1624

days inactive

1626

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)