Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44150 )
Change subject: nb/intel/x4x: Remove dead assignments ......................................................................
nb/intel/x4x: Remove dead assignments
The call to `decode_pcie_bar` always initializes these values.
Change-Id: Iffdb2fc846a6fc1a1abc504370b6283e292b61c0 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/x4x/acpi.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/44150/1
diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c index c700076..4088e75 100644 --- a/src/northbridge/intel/x4x/acpi.c +++ b/src/northbridge/intel/x4x/acpi.c @@ -9,8 +9,7 @@
unsigned long acpi_fill_mcfg(unsigned long current) { - u32 pciexbar = 0; - u32 length = 0; + u32 pciexbar, length;
if (!decode_pcie_bar(&pciexbar, &length)) return current;
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44150 )
Change subject: nb/intel/x4x: Remove dead assignments ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44150 )
Change subject: nb/intel/x4x: Remove dead assignments ......................................................................
nb/intel/x4x: Remove dead assignments
The call to `decode_pcie_bar` always initializes these values.
Change-Id: Iffdb2fc846a6fc1a1abc504370b6283e292b61c0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44150 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/x4x/acpi.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c index c700076..4088e75 100644 --- a/src/northbridge/intel/x4x/acpi.c +++ b/src/northbridge/intel/x4x/acpi.c @@ -9,8 +9,7 @@
unsigned long acpi_fill_mcfg(unsigned long current) { - u32 pciexbar = 0; - u32 length = 0; + u32 pciexbar, length;
if (!decode_pcie_bar(&pciexbar, &length)) return current;