Change in coreboot[master]: mb/system76/lemp9: gpio: convert the remaining raw pads to macros
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43648 )
Change subject: mb/system76/lemp9: gpio: convert the remaining raw pads to macros ......................................................................
Patch Set 26:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43648/26/src/mainboard/system76/lem... File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/43648/26/src/mainboard/system76/lem... PS26, Line 141: PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST), this was tested; touchpad is working fine
https://review.coreboot.org/c/coreboot/+/43648/26/src/mainboard/system76/lem... PS26, Line 281: PAD_CFG_GPI_SCI(GPP_D9, NONE, DEEP, LEVEL, INVERT), this is, what the vendor sets; I'm not sure how to check if that is correct. I'm also unsure about that INVERT
https://review.coreboot.org/c/coreboot/+/43648/26/src/mainboard/system76/lem... PS26, Line 364: PAD_CFG_GPI_SMI(GPP_E15, NONE, PLTRST, EDGE_SINGLE, NONE), this is, what the vendor sets; I'm not sure how to check if that is correct.
https://review.coreboot.org/c/coreboot/+/43648/26/src/mainboard/system76/lem... PS26, Line 366: PAD_CFG_GPI_SCI(GPP_E16, NONE, PLTRST, LEVEL, INVERT), this is, what the vendor sets; I'm not sure how to check if that is correct. I'm also unsure about that INVERT
-
Michael Niewöhner (Code Review)