Change in coreboot[master]: soc/qualcomm/common: Make clock_configure() check for exact matches
Attention is currently required from: Taniya Das, Paul Menzel, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Make clock_configure() check for exact matches ......................................................................
Patch Set 7:
(2 comments)
File src/soc/qualcomm/common/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/d94b41c9_abd077c7 PS6, Line 104: die("Failed to find a matching clock frequency!\n");
You should print hz and the clk (rcg) pointer in this message so it's possible to understand what ex […]
Done
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/b362825d_78be9a78 PS6, Line 425: return clock_configure((struct clock_rcg *)
Does this work? Note that this function never initializes mdss_clk_cfg. […]
Ok this is a good point. This function is actually not called yet (until CB:61342), so it didn't throw an error when testing.
-
Shelley Chen (Code Review)