Attention is currently required from: Daniel Schaefer, Kieran Levin, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81978?usp=email )
Change subject: mb/framework: Initial push of azalea (Framework 13 AMD 7040)
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File src/mainboard/framework/azalea/bootblock.c:
https://review.coreboot.org/c/coreboot/+/81978/comment/4ae0b3f8_9069d408 :
PS5, Line 3: #include <bootblock_common.h>
nit: add blank line
File src/mainboard/framework/azalea/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/81978/comment/83e053ff_1c0b5a9c :
PS5, Line 12: )
nit: remove that tab
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81978?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief4b5c75471a2ef5bedaaee9b4737510c2826b6e
Gerrit-Change-Number: 81978
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Daniel Schaefer
dhs@frame.work
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kieran Levin
ktl@frame.work
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jean Lucas
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Daniel Schaefer
dhs@frame.work
Gerrit-Attention: Kieran Levin
ktl@frame.work
Gerrit-Comment-Date: Thu, 25 Apr 2024 17:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment