Attention is currently required from: Wilson Chou, Marc Jones, Jonathan Zhang, Ryback Hung, Johnny Lin, Paul Menzel, Tim Wawrzynczak, Shuming Chu (Shuming).
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67264 )
Change subject: device: Clear lane error status
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67264/comment/056b7fdd_16a401ec
PS4, Line 13: at the end of PCIe link training
rather "after all PCIe link training."
Patchset:
PS2:
No, it’s not suitable to implement that in pciexp_retrain_link() since common clock is hardware desi […]
Well, that's the only link training triggered by corebooot. If we want to do
it for any link training that happened until this point, that's also ok. But
we need to be aware that we'd also clear lane errors that happened after the
link training. Because we have been using the link already at this point.
Maybe that's worth a code comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6344223636409d8fc25e365a6375fc81e69f41a5
Gerrit-Change-Number: 67264
Gerrit-PatchSet: 4
Gerrit-Owner: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Mon, 05 Sep 2022 11:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Wilson Chou
wilson.chou%quantatw.com@gtempaccount.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment