Attention is currently required from: Dinesh Gehlot, Harrie Paijmans, Intel coreboot Reviewers, Jayvik Desai, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87243?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: device/pci_ids: Add Amstonlake CPU IDs
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87243/comment/85e4c665_c1e807b6?usp... :
PS2, Line 7: Amstonlake
Amston Lake
https://review.coreboot.org/c/coreboot/+/87243/comment/eda494be_68d98bac?usp... :
PS2, Line 13: Alderlake
Alder Lake
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/87243/comment/b9a44d35_4158d728?usp... :
PS2, Line 4430: #define PCI_DID_INTEL_ASL_ID_1 0x4675
: #define PCI_DID_INTEL_ASL_ID_2 0x4674
: #define PCI_DID_INTEL_ASL_ID_3 0x4632
Is the mapping 1 to 0x4675 from the datasheet, or could the smaller number 0x4632 be 1?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87243?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia43945887e7d536b5b7387a4dda4e245973c27ee
Gerrit-Change-Number: 87243
Gerrit-PatchSet: 2
Gerrit-Owner: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Comment-Date: Thu, 10 Apr 2025 07:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No