Attention is currently required from: Michał Żygowski, Sergii Dmytruk, ron minnich.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67063 )
Change subject: mb/raptor-cs/talos-2: add basic mainboard structure
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/raptor-cs/talos-2/bootblock.c:
https://review.coreboot.org/c/coreboot/+/67063/comment/5724ad24_525da64d
PS5, Line 56: aspeed_early_config(serial_dev, vuart_init, ARRAY_SIZE(vuart_init));
I think we should skip this file altogether. Based on https://github.com/open-power/docs/issues/25 UART is already properly set up by BMC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c4f74c7b27c8bb5599d68305adf369ddc6fcc70
Gerrit-Change-Number: 67063
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 06 Mar 2023 14:25:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment