Change in coreboot[master]: mb/google/brya/var/banshee: Add SODIMM support - coreboot-gerrit

19 Jan 2022


      Attention is currently required from: Subrata Banik, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61192 )
Change subject: mb/google/brya/var/banshee: Add SODIMM support
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: 
Just copied from brask :p we don't need ram_id so gpio does not need.
File src/mainboard/google/brya/variants/banshee/memory.c:
https://review.coreboot.org/c/coreboot/+/61192/comment/31e46708_fda1f0b9 
PS2, Line 3: #include <baseboard/gpio.h>
...
do we need this ?
Done
https://review.coreboot.org/c/coreboot/+/61192/comment/a85ffa42_812fbc65 
PS2, Line 5: #include <gpio.h>
...
do we need this ?
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d2fe986b786b3553b67910b589fce12647ee69a
Gerrit-Change-Number: 61192
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 19 Jan 2022 07:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment