Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29967 )
Change subject: qclib: Add qclib support with interface tables
......................................................................
Patch Set 30:
(2 comments)
https://review.coreboot.org/#/c/29967/30/src/mainboard/google/mistral/Makefi...
File src/mainboard/google/mistral/Makefile.inc:
https://review.coreboot.org/#/c/29967/30/src/mainboard/google/mistral/Makefi...
PS30, Line 16: romstage-y += romstage.c
duplicate line?
https://review.coreboot.org/#/c/29967/30/src/soc/qualcomm/qcs405/include/soc...
File src/soc/qualcomm/qcs405/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/29967/30/src/soc/qualcomm/qcs405/include/soc...
PS30, Line 45: 0x1000
please pick one style and use it (given everything else, 4096?). Also see Julius' earlier comment about minimum required alignment size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I534af71163d034ea04420dda6a94ce31b08c8a07
Gerrit-Change-Number: 29967
Gerrit-PatchSet: 30
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Mon, 17 Jun 2019 09:47:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment