Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57836 )
Change subject: soc/amd,intel/common/include/gpio: improve documentation of overrides ......................................................................
soc/amd,intel/common/include/gpio: improve documentation of overrides
Explicitly point out that gpio_configure_pads_with_override will ignore GPIOs that are only in the override configuration, but not in the base configuration.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I1bdfcac89b81fef773938133a2699897c6ee9415 --- M src/soc/amd/common/block/include/amdblocks/gpio_banks.h M src/soc/intel/common/block/include/intelblocks/gpio.h 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/57836/1
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h index bb82c10..489bb5c 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_banks.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_banks.h @@ -67,7 +67,8 @@ * This function configures raw pads in base config and applies override in * override config if any. Thus, for every GPIO_x in base config, this function * looks up the GPIO in override config and if it is present there, then applies - * the configuration from override config. + * the configuration from override config. GPIOs that are only specified in the + * override, but not in the base configuration, will be ignored. */ void gpio_configure_pads_with_override(const struct soc_amd_gpio *base_cfg, size_t base_num_pads, diff --git a/src/soc/intel/common/block/include/intelblocks/gpio.h b/src/soc/intel/common/block/include/intelblocks/gpio.h index 8496db3..c47f908 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio.h @@ -186,7 +186,8 @@ * This function configures raw pads in base config and applies override in * override config if any. Thus, for every GPIO_x in base config, this function * looks up the GPIO in override config and if it is present there, then applies - * the configuration from override config. + * the configuration from override config. GPIOs that are only specified in the + * override, but not in the base configuration, will be ignored. */ void gpio_configure_pads_with_override(const struct pad_config *base_cfg, size_t base_num_pads,