Attention is currently required from: Aamir Bohra, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Aamir Bohra. ( https://review.coreboot.org/c/coreboot/+/86599?usp=email )
Change subject: mb/google/brya: Add support to get sku ID
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Is there something for google mainboard common?
let me ask, I assume you are planning to add skuid implementation for CrOS devices alone ? if yes, then you can do something like this
1. Add choice menu for SKUID (CONFIG_CROS_SKUID) selection between CONFIG_SKUID_VIA_CHROMEEC or CONFIG_SKUID_VIA_ADC_PIN
2. if CONFIG_CROS_SKUID is enabled add sku_id.c inside vendor code (or else where as applicable)
3. Inside sku_id.c you can keep two implementation
- retrieve skuid using CrEC
- retrieve skuid using ADC PIN
4. Then allow the main boards to choose how they wish to support SKUID (like HAVE_SKUID_VIA_CHROMEEC or HAVE_SKUID_VIA_ADC_PIN).
I assume non-CrOS main board doesn't fill or implement SKUID() function so, we won't impact those
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55a9d83871f41e191574e554fe7d287c1ee60bd
Gerrit-Change-Number: 86599
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamirbohra@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Aamir Bohra
aamirbohra@google.com
Gerrit-Comment-Date: Thu, 27 Feb 2025 03:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Aamir Bohra
aamirbohra@google.com