Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
soc/amd/common: Add missing stdint.h to BiosCallOuts.h
Change-Id: Ib0eea9bfd0c8d9e3eba257b561980accf5b4bab4 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/35267/1
diff --git a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h index 829630b..9205499 100644 --- a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h +++ b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h @@ -18,6 +18,7 @@ #define __CALLOUTS_AMD_AGESA_H__
#include <amdblocks/agesawrapper.h> +#include <stdint.h>
#define BIOS_HEAP_SIZE 0x30000 #define BSP_STACK_BASE_ADDR 0x30000
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35267/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35267/1//COMMIT_MSG@8 PS1, Line 8: Please declare why it's needed.
Hello Richard Spiegel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35267
to look at the new patch set (#2).
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
soc/amd/common: Add missing stdint.h to BiosCallOuts.h
Include the file containing the typedefs for uint_*.
Change-Id: Ib0eea9bfd0c8d9e3eba257b561980accf5b4bab4 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/35267/2
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
Patch Set 2: Code-Review+2
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h:
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... PS2, Line 21: #include <stdint.h> amdblocks/agesawrapper.h already include stdint.h
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35267/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35267/1//COMMIT_MSG@8 PS1, Line 8:
Please declare why it's needed.
Done
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h:
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... PS2, Line 21: #include <stdint.h>
amdblocks/agesawrapper.h already include stdint. […]
AFAIK we try to overtly add includes to files using a definition, typedef, etc. vs. relying on them being layered.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h:
https://review.coreboot.org/c/coreboot/+/35267/2/src/soc/amd/common/block/in... PS2, Line 21: #include <stdint.h>
AFAIK we try to overtly add includes to files using a definition, typedef, etc. vs. […]
yep, implicit includes tend to cause issues
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35267 )
Change subject: soc/amd/common: Add missing stdint.h to BiosCallOuts.h ......................................................................
soc/amd/common: Add missing stdint.h to BiosCallOuts.h
Include the file containing the typedefs for uint_*.
Change-Id: Ib0eea9bfd0c8d9e3eba257b561980accf5b4bab4 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35267 Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Richard Spiegel: Looks good to me, approved
Objections: Name of user not set #1002476: I would prefer that you didn't submit this
diff --git a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h index 829630b..9205499 100644 --- a/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h +++ b/src/soc/amd/common/block/include/amdblocks/BiosCallOuts.h @@ -18,6 +18,7 @@ #define __CALLOUTS_AMD_AGESA_H__
#include <amdblocks/agesawrapper.h> +#include <stdint.h>
#define BIOS_HEAP_SIZE 0x30000 #define BSP_STACK_BASE_ADDR 0x30000
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)
-
Name of user not set (Code Review)
-
Richard Spiegel (Code Review)