Attention is currently required from: Dinesh Gehlot, Eric Lai, Frank Chu, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81445?usp=email )
Change subject: mb/google/nissa/var/glassway: Update the VccIn Aux Imon IccMax
......................................................................
Patch Set 6:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81445/comment/cdf125d7_aa30297c :
PS6, Line 7: Update the VccIn Aux Imon IccMax
Set VccIn Aux Imon IccMax to 25 A
https://review.coreboot.org/c/coreboot/+/81445/comment/952369d1_3383cf9c :
PS6, Line 9: MBVR
What does that mean?
https://review.coreboot.org/c/coreboot/+/81445/comment/d679262c_52cea9be :
PS6, Line 9: Iccmax of VccIn_Aux is 25A with MBVR design.
What is the current default?
File src/mainboard/google/brya/variants/glassway/ramstage.c:
https://review.coreboot.org/c/coreboot/+/81445/comment/e6932586_4a5d25a7 :
PS6, Line 7: 25*4 For ADL-N
25 * 4 for ADL-N
https://review.coreboot.org/c/coreboot/+/81445/comment/c8c5df16_fb4890b5 :
PS6, Line 7: //
One space?
https://review.coreboot.org/c/coreboot/+/81445/comment/6c4f3b3c_51ac8b48 :
PS6, Line 10:
Remove blank line, if possible (or Gerrit bug).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81445?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I105dc9df53c624fd7fc697408a1097e023a3cd68
Gerrit-Change-Number: 81445
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 27 Mar 2024 22:35:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment